Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.3.1 double free or corruption (fasttop) on 2nd xrootd.monitor #1488

Closed
adriansev opened this issue Aug 3, 2021 · 9 comments
Closed

5.3.1 double free or corruption (fasttop) on 2nd xrootd.monitor #1488

adriansev opened this issue Aug 3, 2021 · 9 comments
Assignees

Comments

@adriansev
Copy link
Contributor

Hi! I'm trying to add another instance of xrootd.monitor and i get :

*** Error in `/usr/bin/xrootd': double free or corruption (fasttop): 0x00000000011ea040 ***
======= Backtrace: =========
/lib64/libc.so.6(+0x81329)[0x7f75bca8c329]
/lib64/libXrdServer.so.3(_ZN17XrdXrootdProtocol4xmonER12XrdOucStream+0x67)[0x7f75bdf6da77]
/lib64/libXrdServer.so.3(_ZN17XrdXrootdProtocol6ConfigEPKc+0x548)[0x7f75bdf6bad8]
/lib64/libXrdServer.so.3(_ZN17XrdXrootdProtocol9ConfigureEPcP18XrdProtocol_Config+0x20a)[0x7f75bdf6bdba]
/lib64/libXrdServer.so.3(XrdgetProtocol+0x5f)[0x7f75bdf7c32f]
/usr/bin/xrootd(_ZN11XrdProtLoad4LoadEPKcS1_PcP18XrdProtocol_Configb+0x48)[0x40f3f8]
/usr/bin/xrootd(_ZN9XrdConfig5SetupEPcS0_+0x249)[0x40b5e9]
/usr/bin/xrootd(_ZN9XrdConfig9ConfigureEiPPc+0xd6e)[0x40d3ce]
/usr/bin/xrootd(main+0x7c)[0x4073ac]
/lib64/libc.so.6(__libc_start_main+0xf5)[0x7f75bca2d555]
/usr/bin/xrootd[0x407595]

any idea on this? i would like to have another monitoring destination with other configuration and content than the first instance...
Thank you!

@xrootd-dev
Copy link

xrootd-dev commented Aug 3, 2021 via email

@adriansev
Copy link
Contributor Author

@xrootd-dev so, this is the configuration:

xrootd.monitor all flush 60s window 30s dest files fstat info user alien.MY_DOMAIN:9930
#xrootd.monitor all flush 60s window 30s files fstat sev.MY_DOMAIN:49000

uncommenting the second line triggers the breakage
Thanks a lot!

@abh3 abh3 self-assigned this Aug 3, 2021
@abh3
Copy link
Member

abh3 commented Aug 4, 2021

So, this was a holdover from a change we made to how the monitor directive works. The way you did this would not accomplish what you wanted as the second monitor directive would completely override the first (It's always been that way). However, people complained that the directive became way to wordy and difficult to manage. So, we introduced the '...' paradigm which should be used here (your other alternative to use backslash continuation like you do in make files which was the old way of doing it and still supported). Anyway, take a look at
https://xrootd.slac.stanford.edu/doc/dev53/xrd_config.htm#_Toc60181795
along with '...' to accomplish what you want. That said, thanks for tripping over this. It's now fixed in master and will be included in the next bugfix release.

@abh3 abh3 closed this as completed Aug 4, 2021
@adriansev
Copy link
Contributor Author

@abh3 well, ok, but ii do not want a continuation .. i just want a different set of metrics to a different destination .. or did i get ... wrong?
would the following work?:

xrootd.monitor set_options_1 destination1
xrootd.monitor ... set_options_2 destination2

@abh3
Copy link
Member

abh3 commented Aug 4, 2021 via email

@adriansev
Copy link
Contributor Author

@abh3 hm.. ok, then, should i fill a "feature request" for distinct instances of monitor, each with own metrics and destination for sending?
is it technically possible?
Thanks a lot!

@abh3
Copy link
Member

abh3 commented Aug 4, 2021 via email

@adriansev
Copy link
Contributor Author

i see, it's ok then, i can send the reunion of the metrics and each destination filters what it needs...
Thanks!

@abh3
Copy link
Member

abh3 commented Aug 4, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants