Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrootd build requires:: libxml2 vs tinyxml #1924

Closed
adriansev opened this issue Feb 21, 2023 · 4 comments
Closed

xrootd build requires:: libxml2 vs tinyxml #1924

adriansev opened this issue Feb 21, 2023 · 4 comments

Comments

@adriansev
Copy link
Contributor

I noticed that there are 2 xml requirements: lixml2 and tinyxml.
Are these 2 both needed? is tinyxml supposed to supersede libxml2?
Thanks a lot for any clarification!

@xrootd-dev
Copy link

xrootd-dev commented Feb 22, 2023 via email

@adriansev
Copy link
Contributor Author

Actually it's more complicated than that. Originally we simply used our own version of tinyxml (see xrootd/src/XrdXml/tinyxml) and there were no explicit dependencies; though we allowed sites to optionally use libxml2 just in case there was a problem with our version of tinyxml. Then we ran into an EPEL rule that says that we cannot do that if a site has installed tinyxml and if it has then we are supposed to use the installed version. So, somewhere in that whole process these additional requirements were imposed but I don't know the history behind that. So, the answer is in reality there need not be any requirements but the distrib bureacracy says otherwise.

so.. would that mean that tintxml is redundant and the only (prefered) requirement is libxml2?
maybe this could use some clean up? i see in src/XrdXml/XrdXmlReader.cc:50 that if libxml2 is present it will always be used but the cmake configuration allows both to be present (and linked against?) which could be messy..

So, would be possible to make them exclusive? (as a first step)
Then, given that both are widely distributed, maybe just use only one of them?
Thanks a lot!

@amadio amadio self-assigned this Feb 22, 2023
@abh3
Copy link
Member

abh3 commented Feb 22, 2023 via email

@abh3
Copy link
Member

abh3 commented Oct 12, 2023

Working now successfully as designed.

@abh3 abh3 closed this as completed Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants