XRootD HTTP erroneously returns old Digest header

[bbockelm]

The variable holding the Digest response header, m_digest_header, is not reset between requests. This causes the digest header to be sent when the object is reused by a later request.

Note if the subsequent request sets the Want-Digest header, the stale header is not returned. Hence, it's only set when the client isn't expecting it.

[smithdh]

hi @bbockelm . Shall I open a PR for this, or would you like to do that?

[smithdh]

(And thank you for finding the problem)

[bbockelm]

@smithdh - this fix got incorporated into the PR #1957 (see https://github.com/xrootd/xrootd/pull/1957/files#diff-56f7321e31ac4f62330e63a316d3c25360b99c453e09956a1730052d09c367ebR3020). Let's see if that one gets merged in a timely manner; otherwise, I'll send in the one-liner.

[smithdh]

ah, that's great, thanks.

[xrootd-dev]

It should be available in 5.5.4 coming out shortly after the workshop (well that's the current plan). The fix is tied up is sveral other HTTP issues that we are trying to resolve.

…

On Mon, 13 Mar 2023, Brian P Bockelman wrote: @smithdh - this fix got incorporated into the PR #1957 (see https://github.com/xrootd/xrootd/pull/1957/files#diff-56f7321e31ac4f62330e63a316d3c25360b99c453e09956a1730052d09c367ebR3020). Let's see if that one gets merged in a timely manner; otherwise, I'll send in the one-liner. -- Reply to this email directly or view it on GitHub: #1956 (comment) You are receiving this because you are subscribed to this thread. Message ID: ***@***.***> ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1

[amadio]

@bbockelm Could you please split the fix for this issue into a separate pull request? I think that since #1957 is adding a new feature, and we'd like to apply the fix for this to XRootD 5.5.4, it's better to have just the fix for this as its own commit. Thanks!