XRootD does not compile with Clang 15.x

[amadio]

There are several errors due to redefinition of extern inline functions in XrdPosixPreload:

xrootd/src/XrdPosix/XrdPosixPreload32.cc:375:9: 
  error: redefinition of a 'extern inline' function 'pread' is not supported in C++
ssize_t pread(int fildes, void *buf, size_t nbyte, off_t offset)
        ^
/usr/include/bits/unistd.h:72:1: note: previous definition is here
pread (int __fd, void *__buf, size_t __nbytes, __off_t __offset)
^

We should try to fix this, as eventually XRootD will stop compiling on macOS if we don't.

[xrootd-dev]

So, when did the support for this end or is it just a Clang thing?

…

On Thu, 23 Mar 2023, Guilherme Amadio wrote: There are several errors due to redefinition of `extern inline` functions in XrdPosixPreload: ``` xrootd/src/XrdPosix/XrdPosixPreload32.cc:375:9: error: redefinition of a 'extern inline' function 'pread' is not supported in C++ ssize_t pread(int fildes, void *buf, size_t nbyte, off_t offset) ^ /usr/include/bits/unistd.h:72:1: note: previous definition is here pread (int __fd, void *__buf, size_t __nbytes, __off_t __offset) ^ ``` -- Reply to this email directly or view it on GitHub: #1975 You are receiving this because you are subscribed to this thread. Message ID: ***@***.***> ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1

[amadio]

I looked into this today. The problem is that my distribution has #define _FORTIFY_SOURCE 2 by default and Clang doesn't really like that (with GCC it works fine). So I guess the course of action is to forcibly disable it for Clang. I will open a pull request with a patch.

[amadio]

Alright, just added a commit to the pull request where I'm addressing clang warnings. Also, just for the record, Fedora enabled _FORTIFY_SOURCE 3: https://fedoraproject.org/wiki/Changes/Add_FORTIFY_SOURCE%3D3_to_distribution_build_flags, so this will eventually trickle down to RHEL and Alma.