Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused parameters in XrdSecInterface.hh #337

Closed
bastianbeischer opened this issue Feb 22, 2016 · 8 comments
Closed

Unused parameters in XrdSecInterface.hh #337

bastianbeischer opened this issue Feb 22, 2016 · 8 comments

Comments

@bastianbeischer
Copy link

I'm getting the following warnings when building ROOT against xrootd version ae07ce1 (master branch)

It would be great if these could be fixed.

In file included from /home/beischer/abs/root6/src/root/proof/proofd/src/XrdProofConn.cxx:47:0:
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:193:40: warning: unused parameter ‘inbuff’ [-Wunused-parameter]
virtual int Encrypt(const char _inbuff, // Data to be encrypted
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:194:40: warning: unused parameter ‘inlen’ [-Wunused-parameter]
int inlen, // Length of data in inbuff
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:195:40: warning: unused parameter ‘outbuff’ [-Wunused-parameter]
XrdSecBuffer *_outbuff // Returns encrypted data
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:210:38: warning: unused parameter ‘inbuff’ [-Wunused-parameter]
virtual int Decrypt(const char _inbuff, // Data to be decrypted
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:211:38: warning: unused parameter ‘inlen’ [-Wunused-parameter]
int inlen, // Length of data in inbuff
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:212:38: warning: unused parameter ‘outbuff’ [-Wunused-parameter]
XrdSecBuffer *_outbuff // Buffer for decrypted data
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:227:35: warning: unused parameter ‘inbuff’ [-Wunused-parameter]
virtual int Sign(const char _inbuff, // Data to be signed
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:228:35: warning: unused parameter ‘inlen’ [-Wunused-parameter]
int inlen, // Length of data in inbuff
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:229:35: warning: unused parameter ‘outbuff’ [-Wunused-parameter]
XrdSecBuffer *_outbuff // Buffer for the signature
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:245:37: warning: unused parameter ‘inbuff’ [-Wunused-parameter]
virtual int Verify(const char *inbuff, // Data to be decrypted
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:246:37: warning: unused parameter ‘inlen’ [-Wunused-parameter]
int inlen, // Length of data in inbuff
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:247:37: warning: unused parameter ‘sigbuff’ [-Wunused-parameter]
const char *sigbuff, // Buffer for signature
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:248:37: warning: unused parameter ‘siglen’ [-Wunused-parameter]
int siglen) // Length if signature
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:264:37: warning: unused parameter ‘buff’ [-Wunused-parameter]
virtual int getKey(char *buff = 0, int size = 0) {return -ENOTSUP;}
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:264:51: warning: unused parameter ‘size’ [-Wunused-parameter]
virtual int getKey(char *buff = 0, int size = 0) {return -ENOTSUP;}
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:276:30: warning: unused parameter ‘buff’ [-Wunused-parameter]
virtual int setKey(char *buff, int size) {return -ENOTSUP;}
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:276:40: warning: unused parameter ‘size’ [-Wunused-parameter]
virtual int setKey(char *buff, int size) {return -ENOTSUP;}
@xrootd-dev
Copy link

Hi,

Could you please give details on the OS and its version and on the compiler and its version?

Thanks,

Gerardo GANIS
CERN, PH Dept, SFT group
gerardo.ganis@cern.ch
tel/cell: (+41) 22 767 6439 / 75 411 1128

On 22 Feb 2016, at 16:42, Bastian Beischer notifications@github.com wrote:

I'm getting the following warnings when building ROOT against xrootd version ae07ce1 (master branch)

It would be great if these could be fixed.

In file included from /home/beischer/abs/root6/src/root/proof/proofd/src/XrdProofConn.cxx:47:0:
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:193:40: warning: unused parameter ‘inbuff’ [-Wunused-parameter]
virtual int Encrypt(const char inbuff, // Data to be encrypted
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:194:40: warning: unused parameter ‘inlen’ [-Wunused-parameter]
int inlen, // Length of data in inbuff
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:195:40: warning: unused parameter ‘outbuff’ [-Wunused-parameter]
XrdSecBuffer *outbuff // Returns encrypted data
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:210:38: warning: unused parameter ‘inbuff’ [-Wunused-parameter]
virtual int Decrypt(const char inbuff, // Data to be decrypted
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:211:38: warning: unused parameter ‘inlen’ [-Wunused-parameter]
int inlen, // Length of data in inbuff
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:212:38: warning: unused parameter ‘outbuff’ [-Wunused-parameter]
XrdSecBuffer *outbuff // Buffer for decrypted data
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:227:35: warning: unused parameter ‘inbuff’ [-Wunused-parameter]
virtual int Sign(const char inbuff, // Data to be signed
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:228:35: warning: unused parameter ‘inlen’ [-Wunused-parameter]
int inlen, // Length of data in inbuff
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:229:35: warning: unused parameter ‘outbuff’ [-Wunused-parameter]
XrdSecBuffer *outbuff // Buffer for the signature
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:245:37: warning: unused parameter ‘inbuff’ [-Wunused-parameter]
virtual int Verify(const char *inbuff, // Data to be decrypted
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:246:37: warning: unused parameter ‘inlen’ [-Wunused-parameter]
int inlen, // Length of data in inbuff
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:247:37: warning: unused parameter ‘sigbuff’ [-Wunused-parameter]
const char *sigbuff, // Buffer for signature
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:248:37: warning: unused parameter ‘siglen’ [-Wunused-parameter]
int siglen) // Length if signature
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:264:37: warning: unused parameter ‘buff’ [-Wunused-parameter]
virtual int getKey(char *buff = 0, int size = 0) {return -ENOTSUP;}
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:264:51: warning: unused parameter ‘size’ [-Wunused-parameter]
virtual int getKey(char *buff = 0, int size = 0) {return -ENOTSUP;}
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:276:30: warning: unused parameter ‘buff’ [-Wunused-parameter]
virtual int setKey(char *buff, int size) {return -ENOTSUP;}
^
/opt/xrootd/4.2.3.2.CERN.130.gae07ce1-git/include/xrootd/XrdSec/XrdSecInterface.hh:276:40: warning: unused parameter ‘size’ [-Wunused-parameter]
virtual int setKey(char *buff, int size) {return -ENOTSUP;}

—
Reply to this email directly or view it on GitHub.

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1

@bastianbeischer
Copy link
Author

This is with Arch Linux x86_64, GCC 5.3.0.

g++ --version gives:

g++ (GCC) 5.3.0 Copyright (C) 2015 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Anything else? :)

@abh3
Copy link
Member

abh3 commented Feb 22, 2016

Hi Bastian,

Ah, yes, I thought we had corrected those everywhere they occur.
Apparently, this slipped through the cracks which is suprising. Anyway, it
will be corrected.

Andy

On Mon, 22 Feb 2016, Bastian Beischer wrote:

This is with Arch Linux x86_64, GCC 5.3.0.

g++ --version gives:

g++ (GCC) 5.3.0 Copyright (C) 2015 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Anything else? :)

Reply to this email directly or view it on GitHub:
#337 (comment)

@ljanyst
Copy link
Contributor

ljanyst commented Feb 22, 2016

#323

@ljanyst
Copy link
Contributor

ljanyst commented Feb 22, 2016

See this PR: #323

@bastianbeischer
Copy link
Author

Yes, I can understand why this PR added the parameters back for doxygen.

Unfortunately I think there's no way to refer to the parameter names in the doxygen docu using 'param[in]' etc when the actual parameter names are removed / commented out, safe for preprocessor magic just for doygen (#ifdef DOXYPROCESSING - see also http://doxygen.10944.n7.nabble.com/commented-function-parameters-td3718.html)

You could of course (void) cast the unused arguments before returning ENOTSUP...

@ljanyst
Copy link
Contributor

ljanyst commented Feb 22, 2016

Yes, void casting is the way to go.

@abh3
Copy link
Member

abh3 commented Feb 22, 2016

Yes, I see now what happened. A patch witn unintended side-effects. This
will be fixed. Thanks for pointing it out.

Andy

On Mon, 22 Feb 2016, Lukasz Janyst wrote:

#323

Reply to this email directly or view it on GitHub:
#337 (comment)

simonmichal added a commit that referenced this issue Feb 25, 2016
@simonmichal
Fix unused parametres in XrdSecInterface and XrdFileCacheDecision, fixes
5113762 
 #337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ljanyst @bastianbeischer @abh3 @xrootd-dev