Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrdfs ls lists files multiply #541

Closed
olifre opened this issue Jul 11, 2017 · 7 comments
Closed

xrdfs ls lists files multiply #541

olifre opened this issue Jul 11, 2017 · 7 comments
Assignees

Comments

@olifre
Copy link
Contributor

olifre commented Jul 11, 2017

Maybe this is a configuration issue, but I am not sure... Maybe it's also a visualization bug.

Our setup is:

  • Backing filesystem is a LustreFS.
  • A single xrootd as manager, used only for redirecting.
  • 4 data servers actually used for doing the IO.

However, running
xrdfs storm.physik.uni-bonn.de ls -l /lustre/grid/atlas/atlaslocalgroupdisk/
reveals each file four times, likely since each data server sees the same FS.
storm.physik.uni-bonn.de is our manager.

Using xrdfs ls on a single data-server shows the files only once, as expected.

All servers can access the shared filesystem, and I am using the directive:

cms.dfs limit 0 lookup distrib mdhold 0 redirect verify retries 2

Am I missing something, or is this expected behaviour / an inconvenience / a bug?

@olifre
Copy link
Contributor Author

olifre commented Jul 11, 2017

Additional note: Mounting the FS with xrootdfs, I see each file only once, as expected.

@abh3
Copy link
Member

abh3 commented Jul 11, 2017 via email

@olifre
Copy link
Contributor Author

olifre commented Jul 11, 2017

Well, some people could call it a feature, though obviously, for you, it’s a bug.

Thanks for your reply! This at least clarifies it's not a configuration mistake on my end. Then indeed, I guess what I really want is rather an "enhancement".

That works just fine for JBOD setups but not for DFS setups (i.e. your Lustre setup) and the client really doesn’t know which kind you have.

This raises the question: How does xrootdfs know that? It presents the files only once in our configuration, even though it knows all the data servers. So I guess it does some kind of merging already.

Based on that, I would go with the option to let xrdfs ls do what xrootdfs does. This appears to be the "least surprising" solution for the user.
My guess is, without reading the code, that xrootdfs uses some kind of option "c", i.e. some clever merging.
Does that sound sensible?

Cheers, Oliver

@wyang007
Copy link
Member

wyang007 commented Jul 11, 2017 via email

@olifre
Copy link
Contributor Author

olifre commented Jul 11, 2017

Depend on how you view xrdfs. In some use cases, you may want it to remove the repeated entries. In other cases, one may want it to show those items multiple times

I understand. For me as a user, it was confusing that "ls" shows entries which are actually one and the same file multiple times, so I would at least call it "unexpected" compared to a normal "ls".
Of course, the functionality to see the "inner workings" is crucial for any kind of debugging.

So to summarize: In my humble opinion (and this is only my opinion as a user, not a request), I would suggest the following:

  • xrdfs ls could merge duplicate entries by default, since this is closer to the expectation of a user, and thus less surprising.
  • A new option for xrdfs ls could turn off the merging.
  • For ls -l it might be nice if the data server name / IP is also listed (or, if -l is passed together with -u?). Then the output might be even more helpful, and would feel "correct" even without merging.
  • For ls -u I totally understand the necessity to never merge.

As I said, this is only what I would naïvely expect as a user as more natural behaviour of ls. The suggested changes would of course change the existing behaviour, but not remove any functionality.

@abh3 abh3 assigned abh3 and simonmichal and unassigned abh3 Jul 12, 2017
@abh3
Copy link
Member

abh3 commented Jul 12, 2017

OK, we have it on the list of enhancements. The options you propose seem good start. Let's see where we go from here. Thanks for bringing this up.

@olifre
Copy link
Contributor Author

olifre commented Jul 12, 2017

OK, we have it on the list of enhancements. The options you propose seem good start. Let's see where we go from here. Thanks for bringing this up.

Thanks to you for taking my ideas / proposal into consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants