Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing linker details for some libraries #653

Closed
dmacks opened this issue Feb 5, 2018 · 0 comments
Closed

Missing linker details for some libraries #653

dmacks opened this issue Feb 5, 2018 · 0 comments

Comments

@dmacks
Copy link
Contributor

dmacks commented Feb 5, 2018

libXrdSsi and libXrdSsiLog have either deficient or contradictory flags in src/XrdSsi.cmake, and likewise libXrdThrottle in src/XrdPlugins.cmake. They each have add_library(...SHARED...), but do not have VERSION or SOVERSION data there or in their set_target_properties(). As a result, they get compiled as a shared library (for dyld linking) but do not have the usual versioned and nonversioned file and symlinks. The lack of versioning suggests they are instead runtime-loadable modules (dlopen or something like that), which is consistent with the inline comments that they are plugins. If so, they should be declared as MODULE (like for libXrdHttp in src/XrdHttp.cmake) rather than SHARED. Lots of .cmake are inconsistent about what they call a "library" vs "plugin" or "module" in the inline comments and I don't use xrootd much myself, so I don't know which way to go for fixing it.

On many platforms, this distinction probably doesn't matter. But on OS X, shared-libraries and runtime-loadable modules have different extensions (.dylib vs .so, respectively), and the search algorithms for one context might not find files that have the wrong extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant