Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XrdXrootdProtocol missing copy ctor (GCC 9) #993

Closed
Axel-Naumann opened this issue May 27, 2019 · 2 comments
Closed

XrdXrootdProtocol missing copy ctor (GCC 9) #993

Axel-Naumann opened this issue May 27, 2019 · 2 comments
Assignees

Comments

@Axel-Naumann
Copy link

Fedora 30's GCC complains:

/build/ws/BUILDTYPE/Release/LABEL/ROOT-fedora30/build/XROOTD-prefix/src/XROOTD/src/XrdXrootd/XrdXrootdProtocol.cc: In member function ‘XrdXrootdProtocol XrdXrootdProtocol::operator=(const XrdXrootdProtocol&)’:
/build/ws/BUILDTYPE/Release/LABEL/ROOT-fedora30/build/XROOTD-prefix/src/XROOTD/src/XrdXrootd/XrdXrootdProtocol.cc:234:12: error: implicitly-declared ‘XrdXrootdProtocol::XrdXrootdProtocol(XrdXrootdProtocol&)’ is deprecated [-Werror=deprecated-copy]
  234 |    return *this;
      |            ^~~~
/build/ws/BUILDTYPE/Release/LABEL/ROOT-fedora30/build/XROOTD-prefix/src/XROOTD/src/XrdXrootd/XrdXrootdProtocol.cc:215:19: note: because ‘XrdXrootdProtocol’ has user-provided ‘XrdXrootdProtocol XrdXrootdProtocol::operator=(const XrdXrootdProtocol&)’
  215 | XrdXrootdProtocol XrdXrootdProtocol::operator =(const XrdXrootdProtocol &rhs)
      |                   ^~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
gmake[5]: *** [src/CMakeFiles/XrdServer.dir/build.make:245: src/CMakeFiles/XrdServer.dir/XrdXrootd/XrdXrootdProtocol.cc.o] Error 1
gmake[4]: *** [CMakeFiles/Makefile2:554: src/CMakeFiles/XrdServer.dir/all] Error 2

(And yes I know we shouldn't be building that, but convincing CMake of that is all but trivial...)

Axel-Naumann added a commit to Axel-Naumann/root that referenced this issue May 27, 2019
See xrootd/xrootd#993
In a subsequent commit (not part of v6.18) we will only build the Xrd client!
Axel-Naumann added a commit to root-project/root that referenced this issue May 27, 2019
See xrootd/xrootd#993
In a subsequent commit (not part of v6.18) we will only build the Xrd client!
@simonmichal
Copy link
Contributor

@Axel-Naumann : from what I see this has been fixed about 4 months ago:
https://github.com/xrootd/xrootd/blame/master/src/XrdXrootd/XrdXrootdProtocol.cc#L216

in commit 7c5fc93

@simonmichal simonmichal self-assigned this May 28, 2019
@Axel-Naumann
Copy link
Author

Indeed! Sorry, I missed that: I did have a look but failed to find it :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants