Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added XrdCmsRedirLocal as ofs.cmslib plugin. Allows redirector to red… #1022

Merged
merged 5 commits into from
Sep 6, 2019
Merged

Added XrdCmsRedirLocal as ofs.cmslib plugin. Allows redirector to red… #1022

merged 5 commits into from
Sep 6, 2019

Conversation

panik4
Copy link
Contributor

@panik4 panik4 commented Jul 10, 2019

…irect clients to local filesystem, then using the XrdClLocalFileHandler. Builds on the LocalRedirect changes introduced in 4.8.
Developed for using XRootD on top of shared filesystem Lustre, but can be used for other HPC centers.

PR to add the plug-in as discussed with @abh3
Readme in header as discussed.

I used the same license header we also used for the XrdClLocalFileHandler, I hope thats okay.
Cheers,
Paul

…irect clients to local filesystem using the XrdClLocalFileHandler. Developed for using XRootD on top of shared fs Lustre.
@abh3
Copy link
Member

abh3 commented Jul 27, 2019

Sorry for taking so long to review this. There was a problematic use of the kXR_vernnn flag. This flag is meant to describe protocol versions not client abilities. So, to speed things along I introduced a mechanism to indicate that the client supports local files and thus 'file://" urls.

Ostensibly, one should check XrdOucErrInfo::ucap for XrdOucErrInfo::uLclF and, if set, local files are supported. If XrdOucErrInfo::uUrlOK is also set then you can redirect the client to a local file. This is all in commit 684411 which is in git head.

So, please remove the changes to XProtocol.hh and XrdClXRootDTransport.cc, and change your plugin code to test these flags.

@panik4
Copy link
Contributor Author

panik4 commented Aug 5, 2019

Hey Andy,

I reverted what you mentioned and am now using the new client capabilities you added.

Cheers,
Paul

@xrootd-dev
Copy link

xrootd-dev commented Aug 5, 2019 via email

@abh3 abh3 merged commit 401576b into xrootd:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants