Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirection handling #1024

Merged
merged 3 commits into from
Jul 11, 2019
Merged

Fix redirection handling #1024

merged 3 commits into from
Jul 11, 2019

Conversation

bbockelm
Copy link
Contributor

There were a few issues with redirection handling:

  • Opaque data in the original URL was being added twice; once quoted and once unquoted.
  • The second copy of opaque data duplicated the ? character
  • The resourceplusopaque member did not quote arguments in all cases.

The opaque info gets appended later on in the function a second time.
Without this, the opaque information kept in the resource string
is not a valid resource URL.  This differs from how the header2cgi
worked, which copies over opaque information quoted.
Without this, the hdr2cgi data is dropped on a redirect.
@bbockelm bbockelm mentioned this pull request Jul 10, 2019
@bbockelm
Copy link
Contributor Author

@jthiltges - could you patch this one into the redirector at Nebraska?

@ffurano ffurano merged commit 5b34e6f into xrootd:master Jul 11, 2019
@ffurano
Copy link
Contributor

ffurano commented Jul 11, 2019

Michal, wait a bit please, the testbeds are crunching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants