Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul logging approach for TPC #1156

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Conversation

bbockelm
Copy link
Contributor

Try to consistently give a machine-readable format that is friendly to tools like grep.

Example messages (split over lines for human readability):

200315 14:21:06 1875839 TPC_PullRequest: event=PULL_START, \
    local=/home/bbockelm/hello_world_copy.txt, \
    remote=http://example.com:8000/hello_world_copy.txt, \
    user=(anonymous); Starting a push request
200315 14:21:06 1875839 TPC_PullRequest: event=OPEN_FAIL, \
    local=/home/bbockelm/hello_world_copy.txt, \
    remote=http://example.com:8000/hello_world_copy.txt, \
    user=(anonymous), streams=2, status=401; \
    Unable to create /hello_world_copy.txt; permission denied

Fixes #1049

Try to consistently give a machine-readable format that is friendly
to tools like `grep`.

Example messages (split over lines for human readability):
"""
200315 14:21:06 1875839 TPC_PullRequest: event=PULL_START, \
    local=/home/bbockelm/hello_world_copy.txt, \
    remote=http://example.com:8000/hello_world_copy.txt, \
    user=(anonymous); Starting a push request
200315 14:21:06 1875839 TPC_PullRequest: event=OPEN_FAIL, \
    local=/home/bbockelm/hello_world_copy.txt, \
    remote=http://example.com:8000/hello_world_copy.txt, \
    user=(anonymous), streams=2, status=401; \
    Unable to create /hello_world_copy.txt; permission denied
"""

Fixes xrootd#1049
@bbockelm
Copy link
Contributor Author

@ffurano - I think this is ready to go.

@ffurano
Copy link
Contributor

ffurano commented Mar 23, 2020

Hi Brian, have the configuration file changes been documented?
Could you please resolve the conflict?

@bbockelm
Copy link
Contributor Author

@ffurano - yup, some of these PRs mutually conflicted. Working on this now...

@bbockelm
Copy link
Contributor Author

@ffurano - conflicts resolved and re-tested.

For documentation, this PR introduces the following configuration parameters:

tpc.trace [all | error | warning | info | debug | none]+

The default is equivalent to tpc.trace info warning error. The options are not additive (that is, info does not imply error) except for all; all implies all defined logging levels.

@ffurano ffurano merged commit fb6a9f2 into xrootd:master Mar 24, 2020
@simonmichal simonmichal mentioned this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netlogger Format to log XRootD Transfers/Accesses
2 participants