Initialize the XrdAccEntityInfo structure. #1179
Conversation
|
Once we resolve this, @simonmichal please consider for backport. This is an attempt to fix a periodic segfault observed in 4.11.3. |
bbockelm
force-pushed
the
initialize_info
branch
from
97ce725
to
87784a9
Compare
|
@bbockelm : thanks a lot for the PR, could you please refactor the commit so the initialisation is done in the default constructors ( |
When one vorg is provided and no groups are provided, the `grup` data memeber may be uninitialized on use. This has resulted in periodic segfaults on the SciTokens ACC provider; I'm guessing that `grup` quite often has an initial value of `nullptr`, even when uninitialized. I suspect this hasn't been observed for the VOMS provider because all VOMS server implementations create at least one group; hence this case is never hit.
bbockelm
force-pushed
the
initialize_info
branch
from
87784a9
to
0dd6f4d
Compare
|
@simonmichal - update pushed. Back down to C++03 :( For devtoolset: I found some references online about doing this in EPEL7. It's not clear whether that's an option for EPEL6. Here's what we do in OSG: https://github.com/opensciencegrid/xrootd-lcmaps/blob/master/rpm/xrootd-lcmaps.spec |
|
@simonmichal - build failures look unrelated? |
|
@bbockelm : yes that was me (the build is fixed now), I gave it try and it compiles like a charm now, it's ready to be merged. |
When one
vorgis provided and no groups are provided, thegrupdata memeber may be uninitialized on use. This has resulted in periodic segfaults on the SciTokens ACC provider; I'm guessing thatgrupquite often has an initial value ofnullptr, even when uninitialized.I suspect this hasn't been observed for the VOMS provider because all VOMS server implementations create at least one group; hence this case is never hit.