Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XrdHttp][XrdVoms] Pass parameters specified in the http.secxtractor … #1235

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

esindril
Copy link
Contributor

@esindril esindril commented Jul 2, 2020

…down the chain

Conflicts:
src/XrdHttp/XrdHttpProtocol.cc

@esindril
Copy link
Contributor Author

esindril commented Jul 2, 2020

This allows passing the secxtractor params down the chain. Otherwise enabling debug for the secxtractor library is impossible. Could this also please be backported to the 4.12 branch?

@esindril esindril requested a review from abh3 July 2, 2020 09:11
@abh3
Copy link
Member

abh3 commented Jul 2, 2020

Elvin, clearly your editor is not to task here. It looks like everything has changed because all blank lines have been replaced by, well ,blank lines! It's impossible to review this pull request. Could you re-post this pull request with that issue solved (you can easily see it on github).

@esindril
Copy link
Contributor Author

esindril commented Jul 2, 2020

I was hoping to get rid of those annoying whitespaces and that's why I left them in. Ok, I will make another pull request only for whitespace cleanup. :)

@esindril esindril force-pushed the xrdhttp_voms_params branch 2 times, most recently from 58039ef to 311e697 Compare July 2, 2020 09:53
@esindril
Copy link
Contributor Author

esindril commented Jul 2, 2020

This is good now from my side.

@abh3 abh3 merged commit 52834b9 into xrootd:master Jul 8, 2020
@esindril esindril deleted the xrdhttp_voms_params branch July 8, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants