Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ARM, PPC and S390X compilation (char is unsigned by default) #1274

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Fix ARM, PPC and S390X compilation (char is unsigned by default) #1274

merged 1 commit into from
Aug 28, 2020

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Aug 27, 2020 

/builddir/build/BUILD/xrootd-5.0.1/src/Xrd/XrdProtLoad.cc:172:16: error: comparison is always true due to limited range of data type [-Werror=type-limits]
  172 |    while(*pVec != -2)
      |          ~~~~~~^~~~~
/builddir/build/BUILD/xrootd-5.0.1/src/Xrd/XrdProtLoad.cc:173:20: error: comparison is always false due to limited range of data type [-Werror=type-limits]
  173 |         {if (*pVec == -1)
      |              ~~~~~~^~~~~

@xXxrAinZyian
Copy link 

/builddir/build/BUILD/xrootd-5.0.1/src/Xrd/XrdProtLoad.cc:172:16: error: comparison is always true due to limited range of data type [-Werror=type-limits]
  172 |    while(*pVec != -2)
      |          ~~~~~~^~~~~
/builddir/build/BUILD/xrootd-5.0.1/src/Xrd/XrdProtLoad.cc:173:20: error: comparison is always false due to limited range of data type [-Werror=type-limits]
  173 |         {if (*pVec == -1)
      |              ~~~~~~^~~~~

@xXxrAinZyian
Copy link

Thanks

@simonmichal simonmichal merged commit 0e2c4a5 into xrootd:master Aug 28, 2020
@ellert ellert deleted the signed-char branch August 28, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ellert @xXxrAinZyian @simonmichal