Remove old files

[ellert]

Consider at some point to remove files from the source tree that are no longer used.

[abh3]

This is going to take some review to determine whether these deletions will impact our longer term plans. Normally, we leave "unused" parts because some people still depend on the, we have plans to reintegrate parts of them, provide templates for similar functionality, etc. Leaving the source versions in the repo is rather harmless even if somewhat ugly. What was the motivation for these deletions?

[ellert]

What was the motivation for these deletions?

I tried to phrase this carefully when I said "Consider at some point to remove". That is, I was not expecting this to be immediately accepted. The motivation was mainly to clean up the source distribution to not include dead code that is no longer used.

[abh3]

That's OK, nothing wrong with eliminating dead code as it is ugly and can be confusing. It just means we need to review the pull request to extract the appropriate essence. I do appreciate that you provided a focus target which gives us an important starting point. So, I hope you don't mind that a review will ask for modifications of this pull request. I think this is worth pursuing to its conclusion.

[ellert]

Rebased because the "Remove unused parts of XrdOucCache" commit was no longer relevant after commit f853b74 that removed the same files.

[simonmichal]

Just removed XrdClient: 644354d

[ellert]

Just removed XrdClient: 644354d

I have rebased again. The files changed count went down from 114 to 49.

The XrdCns would need some porting if it should be kept since it currently requires XrdClient that is now removed.

[simonmichal]

XrdCns has been already removed from our builds, but lets wait for @abh3 for the final verdict.

[abh3]

I think we no longer compile that and have no expectations of forward porting it (i.e. it's dead code). Andy

…

On Mon, 7 Dec 2020, Mattias Ellert wrote: > Just removed XrdClient: 644354d I have rebased again. The files changed count went down from 114 to 49. The XrdCns would need some porting if it should be kept since it currently requires XrdClient that is now removed. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #1282 (comment)

[simonmichal]

@ellert : just to let you know, I have removed XrdCns (actually the code has been moved to xrootd/archive repo).

[ellert]

@ellert : just to let you know, I have removed XrdCns (actually the code has been moved to xrootd/archive repo).

@simonmichal : You left the src/XrdCns.cmake file behind (and the out-commented include statement in src/CMakeLists.txt) 😀

[ellert]

I have rebased again. Now there are just 19 files left... (Down from 49.)

[simonmichal]

@simonmichal : You left the src/XrdCns.cmake file behind (and the out-commented include statement in src/CMakeLists.txt) 😀

@ellert : thanks for pointing it out! I removed the left overs in: 9a0b4ec

[ellert]

And we are down to 15 files...

[simonmichal]

I've just removed the obsolete man pages: 256873e

[ellert]

And then they were 11...

[simonmichal]

@ellert : together with @abh3, we just did a review and the verdict is we want to keep following files:

XrdSecgsiAuthzFunDN.cc
XrdXrootdGPFile.hh
XrdPfcAllowDecision.cc 
XrdFrmAdminReloc.cc

Please modify your PR and then we can merge it.

[ellert]

Please modify your PR and then we can merge it.

I have modified the PR as requested.