[XCache] Fix options argument to pgwrite. #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last argument of pgWrite() is opts rather than a size. So in this patch I set the opts to 0. I don't think there's any advantage to specify Verify here, since the data are already available to a cache client by reading from RAM so it would be late to discover a mismatch.
The data almost certainly do match their checksums (if present) since they came from pgRead, so either XrdCl verified received checksums or they were generated based on data received over TLS. (I think XrdCl does always verify received checksums, but protocol spec says it only has to verify if the connection is not TLS. If client didn't verify they could conceivably mismatch if origin sent them mismatching).