[XCache] Improve cinfo consistency, purge file on read size mismatch. #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When wrong number of bytes is returned in a block read, assume that initial file-size estimate was different than the current remote file -- purge the file. - Make two cinfo checksums: one for the core data and another for downloaded state and for access statistics. The logic here is that if core part gets corrupted, I could get nonsensical/wrong values for sizes of the following arrays and thus I thought it's better to check that first. - Add checks for corrupt / nonsensical access stats in previous cinfo file versions. - Remove support for cinfo file version 1. - Do not allow enabling of hdfs mode during configuration parsing: this functionality has not been supported for a while and there is now a better way of potentially re-implementing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wrong number of bytes is returned in a block read, assume
that initial file-size estimate was different than the current
remote file -- purge the file.
Make two cinfo checksums: one for the core data and another for downloaded
state and for access statistics. The logic here is that if core part gets
corrupted, I could get nonsensical/wrong values for sizes of the following
arrays and thus I thought it's better to check that first.
Add checks for corrupt / nonsensical access stats in previous cinfo file
versions.
Remove support for cinfo file version 1.
Do not allow enabling of hdfs mode during configuration parsing:
this functionality has not been supported for a while and there is
now a better way of potentially re-implementing it.