Rename XrdAccAuthorizeObjectAdd to XrdAccAuthorizeObjAdd #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin interface expect XrdAccAuthorizeObjAdd function to exist.
|
Tried applying this as a patch to the osg build but got this: (koji build is here: https://koji.opensciencegrid.org/koji/taskinfo?taskID=325387) |
|
Hi Matayas,
This is because I have not yet merged the pull request. The system has to
run through the CI chain and it seems to be taking forever. However, I
just merged the stuff. So, please try again.
Andy
…On Mon, 14 Dec 2020, Matyas Selmeci wrote:
Tried applying this as a patch to the osg build but got this:
```
[100%] Building CXX object src/XrdSciTokens/CMakeFiles/XrdAccSciTokens.dir/src/XrdAccSciTokens.cc.o
/builddir/build/BUILD/xrootd/xrootd/src/XrdSciTokens/src/XrdAccSciTokens.cc: In function 'XrdAccAuthorize* XrdAccAuthorizeObject(XrdSysLogger*, const char*, const char*)':
/builddir/build/BUILD/xrootd/xrootd/src/XrdSciTokens/src/XrdAccSciTokens.cc:1006:53: error: 'XrdAccAuthorizeObjectAdd' was not declared in this scope
return XrdAccAuthorizeObjectAdd(lp, cfn, parm, 0);
^
/builddir/build/BUILD/xrootd/xrootd/src/XrdSciTokens/src/XrdAccSciTokens.cc:1007:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
cc1plus: all warnings being treated as errors
make[2]: *** [src/XrdSciTokens/CMakeFiles/XrdAccSciTokens.dir/src/XrdAccSciTokens.cc.o] Error 1
make[1]: *** [src/XrdSciTokens/CMakeFiles/XrdAccSciTokens.dir/all] Error 2
make: *** [all] Error 2
```
(koji build is here: https://koji.opensciencegrid.org/koji/taskinfo?taskID=325387)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#1361 (comment)
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
|
|
Michal found a typo I missed in bf5aa96. @matyasselmeci if you want to patch it again, you will need the second patch as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin interface expect XrdAccAuthorizeObjAdd function to
exist.