Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ObjAdd to list of scitokens functions exported #1363

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

djw8605
Copy link
Contributor

@djw8605 djw8605 commented Dec 15, 2020

  • Built
  • Tested

(Still building)

@abh3
Copy link
Member

abh3 commented Dec 16, 2020

Given that this causes problems, could you explain why this pull request was summited? I see no functional reason for it.

@simonmichal
Copy link
Contributor

@djw8605 : could you please instead of merging the master branch into your devel branch, rebase it on master? Merging it as it is now to master would create havoc in history.

@djw8605
Copy link
Contributor Author

djw8605 commented Dec 16, 2020

Rebased to master.

This pull request was requested by the latest testing errors that the OSG experienced. The exact error was that it could not find the object XrdAccAuthorizeObjAdd, which I confirmed with nm -D. The next error in the xrootd log was a failure to find version information for the XrdAccAuthorizeObjAdd function.

@simonmichal
Copy link
Contributor

Thanks!

@simonmichal simonmichal merged commit 60a8e3e into xrootd:master Dec 16, 2020
@djw8605 djw8605 deleted the fix-symbol-export branch December 16, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants