Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UUID library to build xrdpfc_print #1364

Closed
wants to merge 1 commit into from

Conversation

djw8605
Copy link
Contributor

@djw8605 djw8605 commented Dec 15, 2020

This was required in order to build master just now.

@osschar
Copy link
Contributor

osschar commented Dec 15, 2020

@djw8605 @simonmichal why is this needed? Apparently it is pulled in through libXrdCl.

libXrdPfc is also linked against libXrdCl and not libuuid.

And so is xrdfs.

@abh3
Copy link
Member

abh3 commented Dec 16, 2020 via email

@abh3
Copy link
Member

abh3 commented Dec 16, 2020

Could provide a reason of why this dependency is needed when we never needed it before?

@simonmichal
Copy link
Contributor

@djw8605 : on which platform is this needed? From what I see all our CI builds are green:
https://gitlab.cern.ch/dss/xrootd/-/pipelines/2182085

@djw8605
Copy link
Contributor Author

djw8605 commented Dec 16, 2020

I think I may have caught master at just the wrong time? The UUID requirement was needed when I was building on EL7 at commit 7c19090. But I can't replicate the need for uuid when I build from the current master, so I'm closing this pull request as unreproducible.

@djw8605 djw8605 closed this Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants