[XrdTls] Memory leak fixes in XrdTlsTempCA #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jthiltges
commented
Apr 22, 2021
jthiltges
commented
- Free XrdCryptoX509Chain when finished
- Duplicate and close file descriptors to free memory
bbockelm
reviewed
Apr 22, 2021
|
@jthiltges - ran these through Valgrind. All looks good! I'd suggest to merge. |
|
This will be merged after JT updates the pull request to use SysFD which hasn't happened yet. JT? Please be aware we are on a tight timeline for releasing 5.2 and it would be good to have this patch in that release but it won't happen until this change occurs. |
- Free XrdCryptoX509Chain when finished - Duplicate file descriptors (with XrdSysFD_Dup to set O_CLOEXEC) and close to free memory
|
PR updated with Brian's suggestions and squashed. Thank you for your time and attention, and please let me know if there's any further changes needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.