Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around inconsistent type definitions on MIPS #1504

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Sep 5, 2021

The st_rdev field in struct stat (which is 32 bits) is not type dev_t (which is 64 bits)

/<<PKGBUILDDIR>>/src/XrdPosix/XrdPosixAdmin.cc:188:45: error: cannot convert ‘long unsigned int*’ to ‘dev_t*’ {aka ‘long long unsigned int*’}
  188 |    Stat.st_mode   = XrdPosixMap::Flags2Mode(&Stat.st_rdev, sInfo->GetFlags());
      |                                             ^~~~~~~~~~~~~
      |                                             |
      |                                             long unsigned int*
In file included from /<<PKGBUILDDIR>>/src/XrdPosix/XrdPosixAdmin.cc:38:
/<<PKGBUILDDIR>>/src/./XrdPosix/XrdPosixMap.hh:43:46: note:   initializing argument 1 of ‘static mode_t XrdPosixMap::Flags2Mode(dev_t*, uint32_t)’
   43 | static mode_t              Flags2Mode(dev_t *rdv, uint32_t flags);
      |                                       ~~~~~~~^~~
make[4]: *** [src/CMakeFiles/XrdPosix.dir/build.make:85: src/CMakeFiles/XrdPosix.dir/XrdPosix/XrdPosixAdmin.cc.o] Error 1

The st_rdev field in struct stat (which is 32 bits) is not type dev_t
(which is 64 bits)

/<<PKGBUILDDIR>>/src/XrdPosix/XrdPosixAdmin.cc:188:45: error: cannot convert ‘long unsigned int*’ to ‘dev_t*’ {aka ‘long long unsigned int*’}
  188 |    Stat.st_mode   = XrdPosixMap::Flags2Mode(&Stat.st_rdev, sInfo->GetFlags());
      |                                             ^~~~~~~~~~~~~
      |                                             |
      |                                             long unsigned int*
In file included from /<<PKGBUILDDIR>>/src/XrdPosix/XrdPosixAdmin.cc:38:
/<<PKGBUILDDIR>>/src/./XrdPosix/XrdPosixMap.hh:43:46: note:   initializing argument 1 of ‘static mode_t XrdPosixMap::Flags2Mode(dev_t*, uint32_t)’
   43 | static mode_t              Flags2Mode(dev_t *rdv, uint32_t flags);
      |                                       ~~~~~~~^~~
make[4]: *** [src/CMakeFiles/XrdPosix.dir/build.make:85: src/CMakeFiles/XrdPosix.dir/XrdPosix/XrdPosixAdmin.cc.o] Error 1
@simonmichal simonmichal merged commit aab9aed into xrootd:master Sep 15, 2021
@ellert ellert deleted the st_rdev-mipsel-inconsistent branch September 15, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants