Use -pthread #1509
Merged
Use -pthread #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer -pthread over -lpthread if supported by the compiler
This reverts commit 39fcbc8. The -pthread option implies linking to libatomic on riscv64. No need to explicitly link to libatomic if -pthread is used instead of -lpthread.
This is the name defined by FindZLIB.cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the discussion in #1506.
Using ${CMAKE_THREAD_LIBS_INIT} everywhere is more consistent than doing a one-off for the one place where it is strictly necessary.
This also avoids that things break elsewhere in the future if some other part of the code starts using new parts of std::atomic that need libatomic.