Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be nice to older (less clever) compiler versions #1528

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Oct 6, 2021

error: parameter declared 'auto'

error: parameter declared 'auto'
@simonmichal
Copy link
Contributor

Hi @ellert, thanks for the PR. The generic lambdas are part of C++14 standard, which is now officially required for XRootD. What is the platform / use case your are training to satisfy with those changes?

@ellert
Copy link
Contributor Author

ellert commented Oct 6, 2021

What is the platform / use case your are training to satisfy with those changes?

Until now building with -std=gnu++1y using the default compiler in RHEL/CentOS 7 worked.
The C++14 support in this compiler is incomplete, but this was the first time xrootd failed to build because of that.
I don't know if building only with the subset of C++14 supported by the default RHEL 7 compiler is expected to work, but until now it did work. Though that might have been just accidental.

@simonmichal
Copy link
Contributor

Our strategy is now to use devtoolset-7 on RHEL7 platforms. AFAIK this is compatible with EPEL / Fedora, isn't it?

@simonmichal
Copy link
Contributor

@ellert : I will merge this as this is minor change and I suppose it will make your life easier, that said be prepared that we might use C++14 features (e.g. make_unique, lambda capture expression, etc.)

@simonmichal simonmichal merged commit a581f4f into xrootd:master Nov 1, 2021
@ellert ellert deleted the epel7-build branch November 1, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants