Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 512 bits to generate the prime value for DH handshake #1560

Closed
wants to merge 2 commits into from

Conversation

gganis
Copy link
Member

@gganis gganis commented Nov 21, 2021

Increase the number of bits used in the generation of the prime value for the Diffie-Hellman handshake to increse its 'safeness' and to prevent warning/error messages issues by new versions of the Java Bouncy Castle security library .

@ellert
Copy link
Contributor

ellert commented Nov 26, 2021

Until the old pre-openssl3 code is removed, any change to code that exists in two version must be changed twice.
This PR changes the file:
src/XrdCrypto/XrdCryptosslCipher.hh
It must therefore also introduce the same changes to the file:
src/XrdCrypto/openssl3/XrdCryptosslCipher.hh
In order for the two implementations to be equivalent.
The openssl3 version of the code is compilable also with older openssl versions, and should at some point become the only version, but until this happens, changes must be implemented twice.

@simonmichal
Copy link
Contributor

@ellert : noted, I will take care of it later this week.

@simonmichal
Copy link
Contributor

@gganis : as it does not merge cleanly I took the liberty and pushed the commit myself: dd54932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants