ci: Add Fedora build job to GitHub Actions CI #1610
Merged
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewfeickert
commented
Feb 5, 2022
matthewfeickert
force-pushed
the
fix/remove-PYTHON_INSTALLED_FILES-dep-fedora
branch
2 times, most recently
from
c087c74
to
8952b91
Compare
|
@simonmichal This is ready for review. |
|
@matthewfeickert : I just pushed a6a1fda that replaces the use of |
|
P. S. I think we don't need anymore the adjustments to the spec file (but please double check), only the test for the CI. |
matthewfeickert
force-pushed
the
fix/remove-PYTHON_INSTALLED_FILES-dep-fedora
branch
from
8952b91
to
99a4b85
Compare
matthewfeickert
changed the title
matthewfeickert
changed the title
PYTHON_INSTALLED is no longer used anywhere in the codebase, so there is no need to use the --record option for deprecated `python setup.py install` installs.
matthewfeickert
commented
Feb 7, 2022
| @@ -81,8 +81,7 @@ if ( NOT ${VALID_PIP_EXIT_CODE} EQUAL 0 ) | |||
| COMMAND ${PYTHON_EXECUTABLE} ${SETUP_PY} install \ | |||
| ${PIP_INSTALL_VERBOSE_FLAG} \ | |||
| --prefix \$ENV{DESTDIR}/${CMAKE_INSTALL_PREFIX} \ | |||
| ${DEB_INSTALL_ARGS} \ | |||
| --record PYTHON_INSTALLED | |||
| ${DEB_INSTALL_ARGS} | |||
There was a problem hiding this comment.
a6a1fda removed all use of PYTHON_INSTALLED so no need to use --record here anymore.
|
@simonmichal this is ready for review. |
matthewfeickert
deleted the
fix/remove-PYTHON_INSTALLED_FILES-dep-fedora
branch
This was referenced Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1609Following PR #1586, the use ofPYTHON_INSTALLED_FILESis regulated to Python 2 builds only. To guard against Python 3 build looking forPYTHON_INSTALLED_FILESwhen it doesn't exist, have the file only be created underpython2onlyandpython2and3builds. Forpython3onlybuilds usepython3_sitearch.Superseded by a6a1fda.
Add a Fedora 35 build job to the CI.