Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pip] Sanitize release candidate versions to PEP 440 #1623

Merged
merged 1 commit into from
Feb 21, 2022
Merged

[pip] Sanitize release candidate versions to PEP 440 #1623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions bindings/python/setup.py.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ if version.startswith("v"):
version = version[1:]

version_parts = version.split(".")

# Ensure release candidates sanitized to <major>.<minor>.<patch>rc<candidate>
if version_parts[-1].startswith("rc"):
version = ".".join(version_parts[:-1]) + version_parts[-1]
version_parts = version.split(".")

if len(version_parts[0]) == 8:
# CalVer
date = version_parts[0]
Expand Down
5 changes: 5 additions & 0 deletions packaging/wheel/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ def get_version():

version_parts = version.split(".")

# Ensure release candidates sanitized to <major>.<minor>.<patch>rc<candidate>
if version_parts[-1].startswith("rc"):
version = ".".join(version_parts[:-1]) + version_parts[-1]
version_parts = version.split(".")

# Assume SemVer as default case
if len(version_parts[0]) == 8:
# CalVer
Expand Down