Vector cleared after use so it can be shrunk. #1639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I missed something in 5ea2004. The
vector::shrink_to_fit
call atXrdTpcStream.hh
line 133 relies upon the vector size (which used to be always 0) being less than its capacity. (It seems it's only invoked when 'low buffer occupancy' is detected.) Now the (size, capacity) will only ever be either (0, 0) or (m_capacity
,>=m_capacity
), instead of (0, 0) or (0,m_capacity
), soshrink_to_fit
won't be able to fully de-allocate. I don't think it's a functional failure, but it could mean the allocation is retained for longer than expected.By clearing the vector just after its contents are transmitted (and when
m_size
andm_offset
are reset, marking the buffer as empty and available),shrink_to_fit
should become effective again.