Also grant Readdir when token grants read permission. #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This irritating behaviour has been found by @federicaagostini in indigo-iam/wlcg-jwt-compliance-tests#34 (comment) . Thanks! |
olifre
changed the title
Before this change, directory listing is impossible with a read claim, leading to the confusing situation that trying to access files in a directory may return 404 but listing the directory returns permission denied.
|
Hi @olifre - Just had a minute to look at this. I think adding directory listing permission is fine here. Let's merge it! Brian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, directory listing is impossible with a read claim,
leading to the confusing situation that trying to access files in a directory
may return 404 but listing the directory returns permission denied.