chore: Remove unused Python setup files from old workflows #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonmichal This PR is ready for review given Nick's sign off in #1594 (comment). |
matthewfeickert
force-pushed
the
chore/remove-old-python-files
branch
from
9cca232
to
59e292e
Compare
* Remove bindings/python/setup_pypi.py as it is Python 2 only and no longer being used in any workflows for installation of the Python bindings. c.f. Issue 1594 for more information. * Remove dopy.sh as well as it only exists as setup_pypi.py does.
* Remove bindings/python/setup_standalone.py as it is no longer used as one can effectively replace all of its functionality with `python -m pip install --upgrade xrootd`. c.f. Issue 1594 for more information.
matthewfeickert
force-pushed
the
chore/remove-old-python-files
branch
from
59e292e
to
9a6a723
Compare
|
@matthewfeickert i'm not sure if the following have anything to do (in the future) with this PR, but using a tag like v5.4.2-alice1 lead to have in the installation output the following: is there anything to worry about the future? |
@adriansev My assumption is that the installed from pip._vendor.packaging.version import Version
Version("5.4.2") # <Version('5.4.2')>
Version("5.4.3rc1") # <Version('5.4.3rc1')>
Version("5.4.2.alice1") # pip._vendor.packaging.version.InvalidVersion: Invalid version: '5.4.2.alice1'and my assumption is that this is happening to you on a fork that you have where you've made this tag as the existing xrootd/packaging/wheel/publish.sh Lines 3 to 6 in 62d1170 which uses tags to set version info (I learned how the existing system XRootD uses works only by making PRs like #1585, so I don't think that any of this should be obvious). This PR should be totally unrelated from any of the above though, as none of the files being removed here participate in the build or the install (so you should be able to get the same warning on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1594
bindings/python/setup_pypi.pyas it is Python 2 only and no longer being used in any workflows for installation of the Python bindings.dopy.shas well as it only exists as setup_pypi.py does.bindings/python/setup_standalone.pyas it is no longer used as one can effectively replace all of its functionality withpython -m pip install --upgrade xrootd.