chore: Use command -v
over which
for portability
#1658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command -v
is a POSIX safe way to find an executable program. Whilewhich
is very common, it still requires installation on many Linux operating systems, and socommand -v
can offer a more portable alternative with a very low amount of additional cognitive overhead on the maintainers.Additionally, use a subshell,
$()
, over backticks for command substitution as$()
is recommended for multiple reasons including readability.c.f.:
...
(backticks)?I made the decision to leave
which
inxrootd/docker/builds/DockerfileCentos7
Line 6 in 62d1170
and
xrootd/docker/builds/DockerfileCentos8
Line 6 in 62d1170
while no longer required, as I figured that these serve as debugging environments where having
which
handy might be nice for alternative reasons, just as howvim
is installed in them as well.