[Pfc] Implement async read and readV from the perspective of XrdOucCacheIO. #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IO: Use override for virtual methods. File: Cache some frequently used variables in adjacent locations. Info: Coalesce functions SetBufferSize/FileSizeAndCreationTime() into a single function as this all needs to happend at the same time.
Put pfc.blocksize into env XRDPFC.SEGSIZE. Merge ReadV chunks from conscutive blocks if they are about to be requested from the same source (disk or direct). Remove commented out obsolete function declarations in XrdPfcFile.hh.
…default of 64 kB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement async Read, pgRead, and ReadV.
Mark file as complete when final block is successfully written to disk.
Perform sync when file is completely downloaded, do not wait for final detach.
Adjust default block size down to 128 kB to be closer to async default of 64 kB.
Rename class IOEntireFile to IOFile.
IO: Use override for virtual methods.
File: Cache some frequently used variables in adjacent locations.
Info: Coalesce functions SetBufferSize/FileSizeAndCreationTime() into a single function as this all needs to happen at the same time.
Put pfc.blocksize into env XRDPFC.SEGSIZE.