[CMake] Make switches for server-only options dependent on XRCL_ONLY=FALSE

[amadio]

Fixes: ff67c2a, Closes: #1804

[amadio]

@simonmichal I guess at least ENABLE_VOMS could be turned into a dependent option as well. Which other options are client-only?

[simonmichal]

@amadio : thanks a lot for the PR :-)

I think, it is worth investigating first why did we run into the problem described in #1804 in the first place, if I read the code correctly, if the XRDCL_ONLY is set to true Macaroons and SciTokens plug-ins should have been excluded from the build:

xrootd/src/CMakeLists.txt

Lines 52 to 88 in 6ef7819

	if( NOT XRDCL_ONLY )
	include( XrdServer )
	include( XrdDaemons )
	include( XrdFrm )
	include( XrdFfs )
	include( XrdPlugins )
	include( XrdSsi )
	include( XrdPfc )
	if( CMAKE_COMPILER_IS_GNUCXX )
	include( XrdOssCsi )
	endif()
	if( BUILD_HTTP )
	include( XrdHttp )
	include( XrdTpc )
	endif()
	if( BUILD_MACAROONS )
	include( XrdMacaroons )
	endif()
	if( BUILD_VOMS )
	include( XrdVoms )
	endif()
	if( XRDCEPH_SUBMODULE )
	add_subdirectory( XrdCeph )
	endif()
	if( BUILD_SCITOKENS )
	include( XrdSciTokens )
	include( XrdSecztn )
	endif()
	endif()

or do I miss something?

[amadio]

The lookup for SciTokens and Macaroons happens in cmake/XRootDFindLibs.cmake and that's not protected with if(NOT XRDCL_ONLY). That's why I said maybe moving the calls to find_package(...) into the subdirectories where they are needed could make sense. It's an alternative solution to what I'm proposing here, but may not be as nice if multiple subdirectories depend on the same packages, as those would be needed at top level anyway.

[simonmichal]

@amadio : thanks for the explanation, it all makes sense now!