Fix for issue 1864 #1865
Merged
Fix for issue 1864 #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abh3
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
OK, I now understand why my tests succeeded and yours failed. It was a happenstance of the data we used. So, indeed, this is the correct fix as the verification stops when a bad checksum is encountered and the caller needs to redrive the check where it left off. So, yes, data needs to point to where the verification should resume.
|
Let me know whether you will merge this or want me to do it. I think this is the only place it needs to be fixed or do you have another concern? |
|
I usually hold off on merging my own changes until there is a review/approval. I will merge this and include it also in the next release candidate. I don't think a fix is necessary elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1864.