Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XrdTlsContext: Recreate session cache in the Clone() method #1875

Conversation

ccaffy
Copy link
Contributor

@ccaffy ccaffy commented Dec 21, 2022

This fixes the issue #1874

@ccaffy
Copy link
Contributor Author

ccaffy commented Dec 21, 2022

Hi @abh3 ,

Here is the fix. I tested it both with HTTP and xroots and it works fine.

Cheers,
Cedric

@ccaffy ccaffy requested a review from abh3 December 21, 2022 10:03
Copy link
Member

@abh3 abh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review but we were off the day before this was posted -- 2.5 weeks of bliss :-) Anyway, it looks good so please merge it and thanks for doing the fix!

@abh3 abh3 merged commit 3082b85 into xrootd:master Jan 10, 2023
@abh3
Copy link
Member

abh3 commented Jan 10, 2023

OK, I decided to merge it myself as it was a no brainer!

@ccaffy
Copy link
Contributor Author

ccaffy commented Jan 10, 2023

Thanks @abh3 and happy new year!

@ccaffy ccaffy deleted the 1874-TLS-SessionTicket-enabled-after-certificate-refresh branch May 30, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants