core: Update genversion.sh script work as expected in --print-only mo… #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amadio
reviewed
Feb 7, 2023
genversion.sh
Outdated
| done | ||
| fi | ||
|
|
||
| echo "user version: ${USER_VERSION} and sourcepath: ${SOURCEPATH}" |
There was a problem hiding this comment.
Is this statement meant to be in the final version?
…de with user given version
esindril
force-pushed
the
fix-genversion-script
branch
from
225a29f
to
04b5813
Compare
|
No ... fixed! :) |
|
This is already fixed in master. All works fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…de with user given version
The behavior of the genversion.sh script does not work as advertised for the --print-only flag. Namely when passing the USER_VERSION parameter this is not taken into consideration. As it's the case when used from this location:
https://github.com/xrootd/xrootd/blob/master/packaging/makesrpm.sh#L137
This pull request fixes this issue and makes the general behavior more consistent with the expectations.