Adjust build rules to not depend on scitokenscpp to build libXrdSecztn #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some changes are also necessary in the spec file to reflect the changes in CMake. I will take care of that and push a new patch later. |
This partially reverts commit 984efbc. Actually, libXrdSecztn doesn't depend on scitokens-cpp, so we can always build it even when -DENABLE_SCITOKENS=FALSE. Therefore, also remove the conditional in the spec file to always include the plugin in xrootd-libs.
amadio
force-pushed
the
client-ztn-scitokens
branch
from
0049042
to
9a7dfda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 984efbc. Actually, libXrdSecztn does not depend on scitokenscpp, we can build it on the client side even when
-DENABLE_SCITOKENS=FALSE.@abh, I believe this is what you meant initially that we should do, right?