Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake improvements and addition of Google Test to start converting existing CppUnit tests to it #1965

Merged
merged 13 commits into from
Mar 20, 2023

Conversation

amadio
Copy link
Member

@amadio amadio commented Mar 15, 2023

Opening a pull request to give others a chance to review this before merging. Will merge tomorrow if there are no objections. The CI system is adapted to run the tests already, including the one I converted as an example.

@amadio amadio self-assigned this Mar 15, 2023
@amadio amadio requested a review from abh3 March 15, 2023 16:31
@ccaffy
Copy link
Contributor

ccaffy commented Mar 16, 2023

All good for me :) Thanks @amadio for this work :)

@amadio amadio added this to the 5.6 milestone Mar 17, 2023
@simonmichal
Copy link
Contributor

I wondering if we shouldn't guard the following block:

%check
 cd xrootd/build
 %if %{use_cmake3}
 ctest3 --output-on-failure
 %else
 ctest --output-on-failure
 %endif

with %if %{?_with_tests:1}%{!?_with_tests:0}, meaning enforce the check only if we are building with _with_tests flag.

Otherwise looks good :-)

@amadio
Copy link
Member Author

amadio commented Mar 17, 2023

We could do that, but it's not necessary, the way it is now, ctest will just do nothing. You can see what happens here, in the fedora-rpm build.

@amadio amadio merged commit 2a51470 into master Mar 20, 2023
@amadio amadio deleted the gtest branch March 20, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants