Fix build failure with latest glibc #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amadio
reviewed
May 22, 2023
Declaration in old version:
extern int fclose (FILE *__stream);
Declaration in new version:
extern int fclose (FILE *__stream) __nonnull ((1));
This change causes a compilation error in xrootd:
/builddir/build/BUILD/xrootd-5.5.5/src/XrdTls/XrdTlsTempCA.cc:54:48: error: ignoring attributes on template argument 'int (*)(FILE*)' [-Werror=ignored-attributes]
54 | typedef std::unique_ptr<FILE, decltype(&fclose)> file_smart_ptr;
| ^
This commit rewrites the code so the error is not triggered.
ellert
force-pushed
the
error-ignored-attributes
branch
from
89c2857
to
de4dea2
Compare
|
@ellert Thanks! |
|
@amadio - do you know if there are any recent C++ improvements for code patterns like this? This sort of smart pointer trickery makes me miss the |
|
I think it may be possible to use something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest updates to glibc headers adds __nonnull to the fclose()
Declaration in old version:
Declaration in new version:
This change causes a compilation error in xrootd:
This commit rewrites the code so the error is not triggered.