Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XrdHttp: Corrected regression where no performance markers were sent to the client during a HTTP TPC transfer #2017

Merged
merged 1 commit into from May 30, 2023

Conversation

ccaffy
Copy link
Contributor

@ccaffy ccaffy commented May 26, 2023

Before this fix, no performance markers were sent to the client after a HTTP TPC transfer was started, there were weird numbers instead:

> COPY /tmp/BIGFILE_10GB HTTP/1.1
> User-Agent: curl/7.29.0
> Host: machine.cern.ch:1096
> Accept: */*
> Destination: https://machine.cern.ch:2001/tmp/BIGFILE_10GB_COPY
>
< HTTP/1.1 201 Created
< Connection: Keep-Alive
< Server: XrootD/v5.2.0-99-osghotfix...687
< Content-Type: text/plain
< Transfer-Encoding: chunked
< 

9b

9c

9c

32

0

After the fix, the perf markers are back:

> COPY /tmp/BIGFILE_10GB HTTP/1.1
> User-Agent: curl/7.29.0
> Host: machine.cern.ch:1096
> Accept: */*
> Destination: https://machine.cern.ch:2001/tmp/BIGFILE_10GB_COPY
> 
< HTTP/1.1 201 Created
< Connection: Keep-Alive
< Server: XrootD/v5.2.0-99-osghotfix...687
< Content-Type: text/plain
< Transfer-Encoding: chunked
< 
Perf Marker
Timestamp: 1685106809
Stripe Index: 0
Stripe Bytes Transferred: 0
Total Stripe Count: 1
End
Perf Marker
Timestamp: 1685106814
Stripe Index: 0
Stripe Bytes Transferred: 1017184256
Total Stripe Count: 1
RemoteConnections: tcp:137.138.123.14:2001
End
Perf Marker
Timestamp: 1685106819
Stripe Index: 0
Stripe Bytes Transferred: 2326478848
Total Stripe Count: 1
RemoteConnections: tcp:137.138.123.14:2001
End

Fixes the regression introduced in 56b2bde

@ccaffy ccaffy requested a review from abh3 May 26, 2023 13:15
@ccaffy
Copy link
Contributor Author

ccaffy commented May 26, 2023

@bbockelm I cannot add you as a reviewer, as I touched your code, can you please review what I did in case?

Thanks in advance !

@amadio
Copy link
Member

amadio commented May 26, 2023

Looks good to me.

@amadio amadio added this to the 5.6 milestone May 30, 2023
@amadio amadio merged commit 7f7caa2 into xrootd:master May 30, 2023
14 checks passed
@ccaffy ccaffy deleted the xrdhttptpc-no-perf-marker-sent branch May 30, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants