Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XrdHttp] A bad request error is returned in the case a client provides too many range requests #2022

Conversation

ccaffy
Copy link
Contributor

@ccaffy ccaffy commented Jun 1, 2023

Fixes issue #2003

@ccaffy
Copy link
Contributor Author

ccaffy commented Jun 1, 2023

If a client asks for more than the maximum amount of vector reads the server can handle, they will get a 400 error "Bad Request" like the following:

reply: 'HTTP/1.1 400 Bad Request\r\n'
header: Connection: Close
header: Server: XrootD/v5.2.0-99-osghotfix...687
header: Content-Length: 74
Too many range requests provided. Maximum range requests supported is 1024

@ccaffy ccaffy requested a review from abh3 June 1, 2023 11:30
Copy link
Member

@abh3 abh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this addresses the issue of a read vector being too long in the first place. However, I think you decided hat there is more work to do on this other than complaining that the number of element in the read vector is too long. So, I don't see anything wrong but I would guess you wan to expand on this pull request to do a more comprehensive patch, right? So, I won't merge this unless you tell me this is what you really want in.

@ccaffy
Copy link
Contributor Author

ccaffy commented Jun 7, 2023

Hi @abh3 ,

You can merge this one. It solves this issue and this issue can therefore be closed. The other problem I am working on related to range-request is in this issue: #1976

Cheers,
Cedric

@abh3 abh3 merged commit fc079d6 into xrootd:master Jun 8, 2023
14 checks passed
@abh3
Copy link
Member

abh3 commented Jun 8, 2023 via email

@ccaffy
Copy link
Contributor Author

ccaffy commented Jun 8, 2023

Thanks, I merged it but I still don't know which related ticket should be closed. Can you give that ticket number?

On Wed, 7 Jun 2023, ccaffy wrote: Hi @abh3 , You can merge this one. It solves this issue and this issue can therefore be closed. The other problem I am working on related to range-request is in this issue: #1976 Cheers, Cedric -- Reply to this email directly or view it on GitHub: #2022 (comment) You are receiving this because you were mentioned. Message ID: @.***>

Closing the ticket, I've put its number in the first comment of this pull request: #2003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XrdHttp: error behavior with large Range requests could be improved
3 participants