Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable XrdEc tests and add simple set of smoke tests for server+client #2044

Merged
merged 5 commits into from
Jun 19, 2023

Conversation

amadio
Copy link
Member

@amadio amadio commented Jun 19, 2023

Supersedes #2041.

@amadio amadio self-assigned this Jun 19, 2023
@amadio amadio requested a review from abh3 June 19, 2023 11:50
@amadio amadio added this to the 5.6 milestone Jun 19, 2023
@amadio amadio force-pushed the testing branch 2 times, most recently from 52c8e7b to 6a48ab2 Compare June 19, 2023 13:04
Copy link
Member

@abh3 abh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional missing spec. See comments. Otherwise fine.

tests/XRootD/smoke.sh Outdated Show resolved Hide resolved
tests/XRootD/xrootd.cfg Outdated Show resolved Hide resolved
This is because some of them may find a port unavailable
as port numbers are fixed in the tests to 9999.
This is necessary to avoid test failures when running tests in
parallel, as they'd be trying to overwrite each other's data in
that case, and also failing tests do not clean up after themselves,
so the following tests all fail if a given test fails.
This is to avoid corruption when running multi-threaded tests.
See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68080.
@amadio amadio merged commit cc0c875 into xrootd:master Jun 19, 2023
14 checks passed
@amadio amadio deleted the testing branch June 19, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants