Conditionally compile support for loading CA files. #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `scitoken_config_set_str` function was only recently added to the SciTokens library; some supported platforms do not plan on taking the updated version. Accordingly, add a CMake-level test to see if the symbol exists and only then make the call to the library.
|
Looks good. I thought scitokens would export a version which we could use to decide, but this works too. I will check tomorrow with my new CI and merge if all goes well. Thank you! |
|
Thanks! This works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scitoken_config_set_strfunction was only recently added to the SciTokens library; some supported platforms do not plan on taking the updated version.Accordingly, add a CMake-level test to see if the symbol exists and only then make the call to the library.
@amadio - it's been a long time since I've done anything non-trivial with cmake. Please double-check you're happy with my approach.