[XrdNet and XrdHttp] Scitag min and max value change #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation (64 < scitag.flow < 65536)
ccaffy
force-pushed
the
scitag-max-value-change
branch
from
c68d7d2
to
5be97d2
Compare
ccaffy
changed the title
amadio
reviewed
Dec 1, 2023
abh3
requested changes
Dec 1, 2023
…for expID and actID Also modified the validation of the scitag provided by the user. Checks whether the expID and actID are within the min and max values. In the case the provided value is not correct, the packets will be marked with a scitag = 0 (expId = 0 and actId = 0)
ccaffy
force-pushed
the
scitag-max-value-change
branch
from
5be97d2
to
85680c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @abh3 ,
I took a bit of time to work on adapting the packet marking to comply with the specification where the
scitag.flowhas to have values between 65 and 65535.I did two commits. The first one is changing the min and max values that a scitag can have and that modifies the
XrdHttppart to check the validity of the scitag value given by the user.The second one also touches the configuration of the scitag configuration from a JSON file (taking into account min and max values). I also modified the validation of the PMark handle where a scitag=0 will only be valid for HTTP-TPC (according to the specs). For other protocols, the scitag given by the user will have to be between 65 and 65535, otherwise the traffic will not be tagged.
Thanks for your review!
Cheers,
Cedric