Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Fix include path in XRootDConfig.cmake #2142

Merged
merged 2 commits into from Dec 4, 2023

Conversation

hahnjo
Copy link
Contributor

@hahnjo hahnjo commented Dec 4, 2023

Headers are installed into the subdirectory xrootd/. This was broken with commit c6e0e59 ("[CMake] Find only XRootD matching XRootDConfig.cmake installation path") released with version 5.6.3.

Headers are installed into the subdirectory xrootd/. This was broken
with commit c6e0e59 ("[CMake] Find only XRootD matching
XRootDConfig.cmake installation path") released with version 5.6.3.
@amadio
Copy link
Member

amadio commented Dec 4, 2023

This was indeed an oversight, there's a change necessary also in utils/xrootd-config, but I'll do that after merging this, i.e., removing the .../xrootd suffix being added here, to avoid having it twice in xrootd-config (see fe268eb). Thanks!

@amadio amadio merged commit ccedaab into xrootd:master Dec 4, 2023
13 checks passed
@hahnjo hahnjo deleted the fix-XRootDConfig branch December 4, 2023 14:02
@amadio
Copy link
Member

amadio commented Dec 4, 2023

Actually, no change needed on the other side, as it uses the variable without /xrootd, we still need to add the suffix there. It's all good!

@amadio amadio added this to the 5.6.4 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants