-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MANIFEST.in for python bindings #268
Conversation
* Adds a MANIFEST.in file for the python bindings.
It is portable, because |
If you really need to generate a standalone python source package, then probably having another |
Hi @otron , Lukasz's suggestion is probably the simplest and cleanest. I've created a branch in my github checkout of xrootd and added a new setup_pypi.py file to properly generate the sdist package. The current one from the XRootD package is not able to do this as the setup.py MANIFEST assumes all the necessary python files are in the same directory which is not the case. Therefore, check it out - it should properly build the sdist pkg. If you are satisfied and all works as you expect it, I can merge it into the master. The downside bit is that it pollutes the xrootd source directory when you create the sdist pkg, but this is a one off when creating the package to put it in PyPI. The alternative would be to copy all into the build directory ... also not nice. The branch I created is: https://github.com/esindril/xrootd/tree/enhance_python_sdist Cheers, |
Looks good! I am working on the tox config file that'll automate the upload process as well as getting installation to work on OSX. |
Hello again, @esindril. The tox script requires the addition of a single config file in the xrootd project directory. Executing it will generate and upload the python package for you, allowing you to easily integrate this with your existing release process. I'll submit a PR to your branch with the required changes when it's ready. |
@esindril: I've created a pull request to your branch with the changes I found necessary to make it work. |
Thanks a lot @otron. I'll have a look over it and include it in the next release. |
Fixed by commit: 98aebca |
setup.py
file generated viasetup.py.in
andcmake
looks for XrootD libraries and resources within the XrootD source directory -- assuming they can be found wherever they were found on the system on which thesetup.py
file was generated. This is not portable.