Missing myFile initialization in XrdXrootdProtocol::Reset #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l object get's recycled
abh3
added a commit
that referenced
this pull request
May 29, 2013
Missing myFile initialization in XrdXrootdProtocol::Reset
|
Thanks for tracking this down. I just merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Justin imposter we managed to track down the crash related to write requests on not open files. When a redirector (as in the case of EOS) can redirect and serve files protocol objects get recycled and the 'myFile' pointer is not reset to 0 in a recycled object. This leads to a SEGV in the WriteNone logic.