New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use scoped lock inside mac-specific XrdSysSemaphore implementation to avoid deadlock on thread cancellation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… avoid deadlock on thread cancellation
Great job figuring this out! Thank you! :) |
ljanyst
added a commit
that referenced
this pull request
Apr 10, 2013
Use scoped lock inside mac-specific XrdSysSemaphore implementation to avoid deadlock on thread cancellation
Closed
Closed
This was referenced Dec 6, 2013
ljanyst
pushed a commit
that referenced
this pull request
Mar 16, 2015
… leading to possible segfaults
Closed
This was referenced Jan 10, 2020
Closed
Closed
amadio
pushed a commit
to amadio/xrootd
that referenced
this pull request
May 12, 2023
Adapt to changes in ceph 15.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a thread is waiting inside XrdSysCondVar::Wait and the thread is cancelled, the mutex is not released, therefore causing deadlock when other threads attempt to lock it.
The simple fix is to use a scoped lock to ensure the mutex is unlocked in the destructor if the thread is cancelled.