Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename InitCTX() to Init() and make it not pure virtual, as requested by Brian #471

Merged
merged 3 commits into from
Mar 1, 2017

Conversation

ffurano
Copy link
Contributor

@ffurano ffurano commented Feb 22, 2017

Please review and let me know.
When this phase is finished we will push the secxtractor library to epel-testing

@ellert
Copy link
Contributor

ellert commented Feb 27, 2017

The signature in 4.5.0 was

// Initializes an ssl ctx
virtual int Init(SSL_CTX *, int) = 0;

So if you wanted to make it backward compatible I don't think this was right. Brian's (@xrootd-dev) comment read:

  • Rename InitCtx back to the original Init
  • Make InitSSL / FreeSSL not pure-virtual (put in the trivial inline implementation in the base class).

i.e. the not pure virtual comment referred to InitSSL and FreeSSL, not Init.

@ellert
Copy link
Contributor

ellert commented Mar 1, 2017

In update 4.6.0-5 in EPEL testing I used the following patch in line with my previous comment:
http://pkgs.fedoraproject.org/cgit/rpms/xrootd.git/plain/xrootd-backward-compat.patch

@ffurano
Copy link
Contributor Author

ffurano commented Mar 1, 2017

Ok, thank you Mattias, so I was missing the second little point. I am making a pull request.

@ffurano
Copy link
Contributor Author

ffurano commented Mar 1, 2017

Actually I added the commit to this pull request.

@ellert
Copy link
Contributor

ellert commented Mar 1, 2017

Shouldn't Init() still be pure virtual though? It was in 4.5.0.

@simonmichal simonmichal merged commit 1d9527a into xrootd:master Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants