Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrootdfs: remove default fuse argument "allow_other" as it is impossible to unset #512

Merged
merged 3 commits into from
May 8, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/XrdFfs/README
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ XROOTDFS_OFSFWD: if the xrootd cluster uses ofs.forward (or ofs.forward 3way)
and expect the operations to be forwarded to the data nodes by the
redirector. Otherwise one can define XROOTDFS_OFSFWD to '0'. XrootdFS will
then go to individual data node for mv/rm/rmdir/trunc.
XROOTDFS_NO_ALLOW_OTHER: do not pass option allow_other to fuse.

Please refer to the "Introduction to the XrootdFS" document in the above web
page for more general idea of XrootdFS.
Expand Down Expand Up @@ -105,6 +106,9 @@ attr_timeout=10
entry_timeout=10
negative_timeout=5

Note that allow_other cannot be unset by command line. To disable it set the
environment variable XROOTDFS_NO_ALLOW_OTHER=1.

Extended file system attributes:
===============================

Expand Down
2 changes: 1 addition & 1 deletion src/XrdFfs/XrdFfsXrootdfs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1233,7 +1233,7 @@ int main(int argc, char *argv[])
cmdline_opts = (char **) malloc(sizeof(char*) * (argc -1 + 3));
cmdline_opts[0] = argv[0];
cmdline_opts[1] = strdup("-o");
if (getenv("XROOTDFS_NOALLOWOTHER") != NULL && ! strcmp(getenv("XROOTDFS_NOALLOWOTHER"),"1") )
if (getenv("XROOTDFS_NO_ALLOW_OTHER") != NULL && ! strcmp(getenv("XROOTDFS_NO_ALLOW_OTHER"),"1") )
cmdline_opts[2] = strdup("fsname=xrootdfs,max_write=131072,attr_timeout=10,entry_timeout=10,negative_timeout=5");
else
cmdline_opts[2] = strdup("fsname=xrootdfs,allow_other,max_write=131072,attr_timeout=10,entry_timeout=10,negative_timeout=5");
Expand Down